vscsyncer: introduce syncer wrapper which calculates latencies for all operations

[ggilmore]

Closes #61692

Test plan

Created the following Grafana screenshot using sg start monitoring:

[ggilmore]

• vscsyncer: introduce syncer wrapper which calculates latencies for all operations #61708 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite

[ggilmore]

Fun fact! If this value is set to git, this completely breaks our templating in non-intuitve ways (starts complaining about illegal characters like $ in metrics like disk_size_remaining where that was never a problem before). I will file an issue about this.

[eseliger]

Very fun indeed 🙃

[eseliger]

Super nit: This reads to me as if this wasn't actually clones, do we need the quotes?

Question: What is "Value" here?

Good stuff! added a few non-blocking comments

[eseliger]

idea: if you embed VCSSyncer directly, you don't have to do things like

func (i *instrumentedSyncer) Type() string {
	return i.base.Type()
}

.. but you would lose the certainty that you correctly overwrote all methods. So no strong opinion here, just something I noticed while reading the diff.

[eseliger]

Very fun indeed 🙃

[sentry]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ *[gitserver] performing background repo update: exit status 128: exec.ExitError: failed to fetch repo ×: failed to set local HEAD to remote HEAD: failed to fetch... github.com/sourcegraph/sourcegraph/cmd/gitserve... View Issue
• ‼️ *[gitserver] performing background repo update: exit status 128: exec.ExitError: failed to fetch repo ×: exit code: 128, failed to fetch from remote: ×: command ... github.com/sourcegraph/sourcegraph/cmd/gitserve... View Issue

_{Did you find this useful? React with a 👍 or 👎}