Upgrade dind version to 26.0.0 to patch vulnerabilities

[willdollman]

The dind image has finally received an update which patches a large number of vulnerabilities! (7 high, 2 critical).

Six months ago when we previously updated dind, there was some discussion about whether it was still used. @sourcegraph/search-platform is there any change to this - are customers still using this image?

Test plan

• Basic local testing
• Any further testing that @sourcegraph/search-platform can think of

[sourcegraph-bot]

📖 Storybook live preview

[willdollman]

Some basic local testing of functionality, building manually then running a container in docker:

will@mac ~> docker build --platform linux/amd64 -t sourcegraph-dind .
[...]

will@mac ~> docker run -it --entrypoint /bin/sh -v /var/run/docker.sock:/var/run/docker.sock sourcegraph-dind

/ # docker run -it --entrypoint /bin/sh alpine:latest
/ #            

[willdollman]

All vulnerabilities patched:

~> trivy image --severity=HIGH,CRITICAL --platform linux/x86_64 docker:26.0.0-dind@sha256:b52760bc3766143ca050ab3f36f01108c30bbd6bc16094400855adfb9bd66f12
2024-04-09T18:04:37.334+0100    INFO    Vulnerability scanning is enabled
2024-04-09T18:04:37.334+0100    INFO    Secret scanning is enabled
2024-04-09T18:04:37.334+0100    INFO    If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-04-09T18:04:37.334+0100    INFO    Please see also https://aquasecurity.github.io/trivy/v0.50/docs/scanner/secret/#recommendation for faster secret detection
2024-04-09T18:04:39.788+0100    INFO    Detected OS: alpine
2024-04-09T18:04:39.789+0100    INFO    Detecting Alpine vulnerabilities...
2024-04-09T18:04:39.793+0100    INFO    Number of language-specific files: 4
2024-04-09T18:04:39.793+0100    INFO    Detecting gobinary vulnerabilities...

docker:26.0.0-dind@sha256:b52760bc3766143ca050ab3f36f01108c30bbd6bc16094400855adfb9bd66f12 (alpine 3.19.1)

Total: 0 (HIGH: 0, CRITICAL: 0)

[jtibshirani]

I think you're looking for our batch changes/ executors experts instead of search platform (which is more narrow). So tagging @camdencheek and @eseliger too!

[willdollman]

Ah thanks for tagging the right people @jtibshirani, the last slack thread mentioned it being owned by search suite which my brain autocompleted to search platform 😁