This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg: cloud ephemeral - add build and upgrade commands#62533
Merged
Conversation
Strum355
approved these changes
May 8, 2024
Strum355
reviewed
May 8, 2024
Strum355
reviewed
May 8, 2024
Strum355
reviewed
May 8, 2024
Strum355
reviewed
May 8, 2024
- fix spelling and formatting --------- Co-authored-by: Noah S-C <noah@sourcegraph.com>
76d6017 to
f801d88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are times when you just want to create a cloud ephemeral deployment. Previously the only way to get a ephemeral build would've been to run
sg cloud deployand then get a deployment failure because a deployment already exists.In this PR we add:
sg cloud buildwhich triggers a cloud ephemeral deploymentsg cloud upgradeto upgrade an existing deploymentsg cloud deployonly creates instances and will not upgrade existing instances. This was done to make the semantics of the commands easier and not conflatedeploywith too much housekeeping tasksTest plan
Tested locally