This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(ci): remove backcompat mitigation#62658
Merged
Conversation
Strum355
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we made backcompat soft fail on exit code 1 due to it failing with a unreproducable error in CI that was not related to the code. Backcompat still tested the database for backwards compatability but the error happened during client code bundling which is unrelated to the backcompat tests - hence the soft fail
With the backcompat bump to 5.4.0 the error isn't happening anymore and we can thus remove the
soft_failmitigationTest plan
CI