This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Merged
Conversation
It needs an event recorder.
b78f250 to
c29dea9
Compare
craigfurman
commented
May 14, 2024
| Scheme: mgr.GetScheme(), | ||
| Client: mgr.GetClient(), | ||
| Scheme: mgr.GetScheme(), | ||
| Recorder: mgr.GetEventRecorderFor("sourcegraph-appliance"), |
Contributor
Author
There was a problem hiding this comment.
Example of how this shows up in events:
❯ kubectl -n test describe configmaps sg
Name: sg
Namespace: test
Labels: deploy=sourcegraph
Annotations: appliance.sourcegraph.com/currentVersion: 5.3.9104
appliance.sourcegraph.com/managed: true
Data
====
spec:
----
spec:
requestedVersion: "5.3.9104"
blobstore: {}
codeInsights:
disabled: true
codeIntel:
disabled: true
frontend:
disabled: true
gitServer:
disabled: true
indexedSearch:
disabled: true
indexedSearchIndexer:
disabled: true
pgsql:
disabled: true
postgresExporter:
disabled: true
preciseCodeIntel:
disabled: true
redisCache:
disabled: true
redisStore:
disabled: true
repoUpdater:
disabled: true
searcher:
disabled: true
symbols:
disabled: true
syntectServer:
disabled: true
worker:
disabled: true
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Normal ReconcileFinished 10s (x2 over 10s) sourcegraph-appliance Reconcile finished.
jdpleiness
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It needs an event recorder.
Test plan
Manually tested by starting the appliance with
go run ./cmd/appliance, and uploading an annotated configmap to a locally-running kubernetes cluster, to start the reconcile loop.