Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

appliance: fix panic on reconcile#62660

Merged
craigfurman merged 1 commit intomainfrom
appliance-fix-panic
May 15, 2024
Merged

appliance: fix panic on reconcile#62660
craigfurman merged 1 commit intomainfrom
appliance-fix-panic

Conversation

@craigfurman
Copy link
Contributor

It needs an event recorder.

Test plan

Manually tested by starting the appliance with go run ./cmd/appliance, and uploading an annotated configmap to a locally-running kubernetes cluster, to start the reconcile loop.

@craigfurman craigfurman requested a review from jdpleiness May 14, 2024 10:59
@cla-bot cla-bot bot added the cla-signed label May 14, 2024
It needs an event recorder.
@craigfurman craigfurman force-pushed the appliance-fix-panic branch from b78f250 to c29dea9 Compare May 14, 2024 11:04
Scheme: mgr.GetScheme(),
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Recorder: mgr.GetEventRecorderFor("sourcegraph-appliance"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example of how this shows up in events:

❯ kubectl -n test describe configmaps sg

Name:         sg
Namespace:    test
Labels:       deploy=sourcegraph
Annotations:  appliance.sourcegraph.com/currentVersion: 5.3.9104
              appliance.sourcegraph.com/managed: true

Data
====
spec:
----
spec:
  requestedVersion: "5.3.9104"

  blobstore: {}

  codeInsights:
    disabled: true

  codeIntel:
    disabled: true

  frontend:
    disabled: true

  gitServer:
    disabled: true

  indexedSearch:
    disabled: true

  indexedSearchIndexer:
    disabled: true

  pgsql:
    disabled: true

  postgresExporter:
    disabled: true

  preciseCodeIntel:
    disabled: true

  redisCache:
    disabled: true

  redisStore:
    disabled: true

  repoUpdater:
    disabled: true

  searcher:
    disabled: true

  symbols:
    disabled: true

  syntectServer:
    disabled: true

  worker:
    disabled: true

Events:
  Type    Reason             Age                From                   Message
  ----    ------             ----               ----                   -------
  Normal  ReconcileFinished  10s (x2 over 10s)  sourcegraph-appliance  Reconcile finished.

@craigfurman craigfurman enabled auto-merge (squash) May 14, 2024 11:05
@craigfurman craigfurman merged commit f9fb392 into main May 15, 2024
@craigfurman craigfurman deleted the appliance-fix-panic branch May 15, 2024 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants