This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
…rsion-constraint-fot-test-mode
kalanchan
approved these changes
May 15, 2024
Contributor
There was a problem hiding this comment.
I'm going to approve for now so that I can test this on SG02 and unblock QA.
@dominiccooney please review afterwards and leave any comments/concerns with the approach.
@taras-yemets if you could update the tests again that would be great.
next steps: we plan on cutting JB 6.0.0 next week, but this PR will unblock us for now. We should think of a way to test VS Code 1.20.0 as well before next week
| { | ||
| // See https://pkg.go.dev/github.com/Masterminds/semver#readme-working-with-pre-release-versions | ||
| name: "jetbrains: pre-release version doesn't match constraint if \"cody-context-filters-allow-pre-release-client-versions\" feature flag is enabled", | ||
| name: "jetbrains: pre-release version doesn't match constraint if \"cody-context-filters-clients-test-mode\" feature flag is enabled", |
Contributor
There was a problem hiding this comment.
can we add one more test here to show that the test will pass if we use a JetBrains version like 5.5.10-nightly ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets version constraints to lower pre-release versions for VS Code and JetBrains Cody extensions if
cody-context-filters-clients-test-modefeature flag is set totrueto enable testing clients Cody Ignore implementation in the prod environment.More context in this thread.
Test plan