This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg/msp: add repo annotation to delivery pipeline#62702
Merged
Conversation
bobheadxi
reviewed
May 15, 2024
dev/managedservicesplatform/internal/resource/deliverypipeline/deliverypipeline.go
Show resolved
Hide resolved
bobheadxi
reviewed
May 15, 2024
bobheadxi
approved these changes
May 15, 2024
Member
|
Ah, didn't realize automerge was on - @jac FYI about my review comments, just docstring suggestions :) |
bobheadxi
reviewed
May 15, 2024
dev/managedservicesplatform/internal/resource/deliverypipeline/deliverypipeline.go
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the repository as an annotation to the delivery pipeline so that we can later query it e.g. from cloud-relay to include a link to the commit in the message we send to slack
I also tried adding annotations to the releases but unfortunately they don't get sent as part of the notification message
side note: the annotations support free-form text without the same limitations the labels have
part of CORE-36
Test plan
locally tested