This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/msp: do not use tfvars file outside of deploy-type 'subscription'#62704
Merged
feat/msp: do not use tfvars file outside of deploy-type 'subscription'#62704
Conversation
bobheadxi
force-pushed
the
msp-remove-tfvars
branch
from
0039e05 to
0d8826f
Compare
jac
approved these changes
May 16, 2024
bobheadxi
added a commit
that referenced
this pull request
May 16, 2024
#62704 introduced a regression due to the changing of the semantics of `rollouts` configuration in code: previously, only the final stage would get it, but with #62704 this became available on all environments, and to infer the final stage a nil-safe helper `rollout.IsFinalStage()` was introduced. This change fixes a missed check migration that causes additional assets to be incorrectly generated for non-final environments. ## Test plan `sg msp generate -all`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CORE-121
The dependency on the generated
tfvarsfile is frustrating for first-time MSP setup because it currently requires-stable=falseto update, and doesn't actually serve any purpose for deploy types other thansubscription(which uses it to isolate image changes that happen on via GitHub actions). This makes it so that we don't generate, or depend on, the dynamictfvarsfile unless you are usingsubscription.I've also added a rollout spec configuration,
initialImageTag, to make the initial tag we provision environments with configurable (as some services might not publishinsidersimages) - see the docstring.Test plan
Inspect output of
sg msp generate -all