This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Allow multiple ranges to be passed to Commits#62705
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
team/product-platform
team/source
eseliger
force-pushed
the
es/05-15-gitserverallowmultiplerangestobepassedtocommits
branch
from
dc9d49a to
5eef1f7
Compare
pjlast
approved these changes
May 16, 2024
This will be useful for commit searches, and is generally supported by git so why not support it here. That also lets you express `A..B` as `B, ^A` if you want to do less string concatenation, for example. Test plan: Made sure all existing callers pass a non-empty string to the slice if they specify the slice at all, and all existing tests still pass.
eseliger
force-pushed
the
es/05-15-gitserverallowmultiplerangestobepassedtocommits
branch
from
5eef1f7 to
83a42f6
Compare
eseliger
deleted the
es/05-15-gitserverallowmultiplerangestobepassedtocommits
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be useful for commit searches, and is generally supported by git so why not support it here. That also lets you express
A..BasB, ^Aif you want to do less string concatenation, for example.Test plan:
Made sure all existing callers pass a non-empty string to the slice if they specify the slice at all, and all existing tests still pass.