This repository was archived by the owner on Sep 30, 2024. It is now read-only.
svelte: Show correct keyboard shortcut on Linux in "search files" button#62729
Merged
svelte: Show correct keyboard shortcut on Linux in "search files" button#62729
Conversation
This commit updates the repo sidebar to show the Linux specific keyboard shorcut for searching files. I initially was just rendering it as a string, but I think makes sense to have some spacing between the individual parts, just like it was done in the sidebar. So I added a new component for rendering platform-specific keyboard shortcuts that applies this style. The current code adds some negative padding, I don't know if that's really necessary.
vovakulikov
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62725
This commit updates the repo sidebar to show the Linux specific keyboard shorcut for searching files.
I initially was just rendering it as a string, but I think makes sense to have some spacing between the individual parts, just like it was done in the sidebar. So I added a new component for rendering platform-specific keyboard shortcuts that applies this style.
The current code adds some negative padding, I don't know if that's really necessary.
(the alignment looks weird on my system due to the font being used)
Test plan
Manual inspection