This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Merged
Conversation
When switching to git-diff-tree, I looked over the fact that it can only work with treeish-es, not with rangespecs. This PR translates ranges to the corresponding equivalents according to the Git docs: `..` -> `A B` `...` -> `$(git merge-base A B) B` Test plan: Verified diffs are now generated properly again, also added another test to our suite.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
team/product-platform
team/source
ggilmore
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching to git-diff-tree, I looked over the fact that it can only work with treeish-es, not with rangespecs.
This PR translates ranges to the corresponding equivalents according to the Git docs:
..->A B...->$(git merge-base A B) BTest plan:
Verified diffs are now generated properly again, also added another test to our suite.