This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
Comment on lines
240
to
242
Contributor
There was a problem hiding this comment.
Why do we need these empty divs?
Contributor
Author
There was a problem hiding this comment.
Because the grid layout needs five columns. If I don't include the empty divs, the layout gets messed up. Tried it.
taras-yemets
approved these changes
May 17, 2024
Contributor
taras-yemets
left a comment
There was a problem hiding this comment.
Approving to unblock. Left a few minor comments inline.
0505815 to
9aac55b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rrhyne left a bunch of feedback in this figma and this Loom that I totally overlooked at first.
This PR contains all the fixes listen in the Figma and Loom (unless I mixed something).
This is a complete list:
Also:
text-uppercaseclass in ADMIN and INVITED labelsTest plan
Here is a 2.5-minute Loom where I demo the changes.