This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
eseliger
approved these changes
May 17, 2024
0xnmn
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally negated a condition here: https://github.com/sourcegraph/sourcegraph/pull/62453/files#diff-e49c67a73cb92dfd40a6015761f04bc49b5e72bd3a22b7faa7dc7c5d1390a305L74. This is a fix to revert that.
It caused this:
to display like this for new users:
and vice versa.
It probably highly impacted our conversion rate for yesterday.
Why didn't we notice this in the code reviews: I probably messed it up when I was addressing feedback, and didn't wait for the re-review to move fast.
Test plan
It worked before, I only changed it by accident.