This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix: Make most syntaxHighlighting config fields optional#62817
Merged
varungandhi-src merged 2 commits intomainfrom May 22, 2024
Merged
fix: Make most syntaxHighlighting config fields optional#62817varungandhi-src merged 2 commits intomainfrom
varungandhi-src merged 2 commits intomainfrom
Conversation
github-actions
bot
added
team/graph
varungandhi-src
force-pushed
the
vg/optional-hlconfig
branch
from
89b47af to
39c37f9
Compare
keynmol
approved these changes
May 21, 2024
varungandhi-src
changed the title
varungandhi-src
force-pushed
the
vg/optional-hlconfig
branch
2 times, most recently
from
8f49aa0 to
4ad8b4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, too many fields are required, which means you need
to specify unnecessary fields when trying to modify only a single
field, such as mapping specific extensions to specific languages.
Fixes https://linear.app/sourcegraph/issue/GRAPH-612
Test plan
Added unit tests for configuration initialization