This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(gha): link to how-to when license check fail#62857
Merged
Conversation
Contributor
|
Tip License checking failed, please see How to deal with third parties licensing |
Contributor
|
Contributor
|
Caution License checking failed, please consult: How to deal with third parties licensing. |
burmudar
approved these changes
May 22, 2024
Contributor
burmudar
left a comment
burmudar
left a comment
There was a problem hiding this comment.
Oh this is a nice touch
Contributor
Author
It's @unknwon's idea, and yeah it's a good one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the license checking action failed, there was no actionnable instructions for the users. This PR adds a conditional step that posts a comment with a link to the how-to in Notion.
I'm using this PR as a way to QA this, hence the few commits to QA each cases.
Test plan
CI + this PR itself (see commits)