This repository was archived by the owner on Sep 30, 2024. It is now read-only.
svelte: Fix failing/skipped playwright tests#62866
Merged
Conversation
Follow up for #62820 to fix failing/skipped tests that are easy to fix (which is all but one).
camdencheek
approved these changes
May 22, 2024
Member
camdencheek
left a comment
camdencheek
left a comment
There was a problem hiding this comment.
Any takeaways other than "we should run playwright in CI"?
Contributor
Author
It's easy to break GraphQL operation overwrites by renaming the query. TypeScript won't help atm because the overwrite API also accepts arbitrary strings, so that we can overwrite requests made by shared code (i.e. graphql queries that are not defined inside OTOH, changing the name of queries might not happen so often that it warrants any other solution then finally running the tests in CI. |
fkling
deleted the
fkling/srch-119-chore-fix-playwright-tests-in-web-sveltekit
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #62820 to fix failing/skipped tests that are easy to fix (which is all but one).
Re-enabling the syntax highlighting error test should be done in a separate PR.
Test plan
pnpm test