This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Embeddings: silence worker log warnings#62884
Merged
jtibshirani merged 2 commits intomainfrom May 23, 2024
Merged
Conversation
github-actions
bot
added
team/product-platform
team/search-platform
eseliger
approved these changes
May 23, 2024
keegancsmith
approved these changes
May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embeddings are disabled by default everywhere. Currently, the indexing job
worker warns if embeddings are disabled, which spams logs and confuses
customers.
This PR just removes the warn logging, as it doesn't serve a helpful purpose.
Test plan
Covered by CI