This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg/msp: support for super-simple alerts on custom metrics#62885
Merged
Conversation
unknwon
reviewed
May 23, 2024
dev/managedservicesplatform/internal/resource/alertpolicy/alertpolicy.go
Outdated
Show resolved
Hide resolved
dev/managedservicesplatform/internal/resource/alertpolicy/alertpolicy.go
Outdated
Show resolved
Hide resolved
dev/managedservicesplatform/internal/resource/alertpolicy/alertpolicy.go
Outdated
Show resolved
Hide resolved
bobheadxi
reviewed
May 24, 2024
bobheadxi
reviewed
May 24, 2024
bobheadxi
reviewed
May 24, 2024
bobheadxi
reviewed
May 24, 2024
Co-authored-by: Joe Chen <joe@sourcegraph.com>
bobheadxi
reviewed
May 24, 2024
bobheadxi
reviewed
May 24, 2024
bobheadxi
reviewed
May 24, 2024
bobheadxi
reviewed
May 24, 2024
bobheadxi
reviewed
May 24, 2024
bobheadxi
added a commit
that referenced
this pull request
Jun 3, 2024
Follow-ups for #62885: - Better docstrings for `mql`, `promql` - `duration` -> `durationMinutes` to align with other config - `alertpolicy.ResponseCodeMetric` -> `spec.CustomAlertCondition`: they're effectively the same type Test plan: CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CORE-16
Currently service owners needs to either rely on our default alerting or use terraform to add custom alerts. With this PR service owners can specify simple custom alerts using MQL or PromQL in the service file e.g.
(ignore bad alerts; just for demonstration purposes)
Test plan
generated alerts using service file config and viewed them in msp alert dashboard
