This repository was archived by the owner on Sep 30, 2024. It is now read-only.
svelte: Add link to code-graph page to repo navigation#62899
Merged
Conversation
This adds a link to the repository's code-graph page to the repo navigation. Additional changes: - added a flag to each menu item that specifies whether or not show the entry for non-admin users (defaults to `false`) - updated vite's proxy configuration to properly load React repo pages from the server
camdencheek
reviewed
May 24, 2024
| ] | ||
| const menuEntries: { path: string; icon: string; title: string }[] = [ | ||
| { path: '/-/compare', icon: mdiHistory, title: 'Compare' }, | ||
| const menuEntries: { path: string; icon: string; title: string; user?: boolean }[] = [ |
Member
There was a problem hiding this comment.
Could we pull this out to a named interface and document the user field? It took me a couple of looks to understand what that field means, so would be nice to be able to document it.
Contributor
Author
There was a problem hiding this comment.
I extracted the interface and also renamed the property to make it more explicit. There shouldn't be any confusion about it now :)
camdencheek
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a link to the repository's code-graph page to the repo navigation.
Additional changes:
false)Test plan
Manual testing. The link shows up and redirects to the React code graph page.