feat(search): Add inline file search to Svelte app#62961
Conversation
fkling
force-pushed
the
fkling/srch-6-svelte-addresolve-file-search-bar
branch
from
d2c49fa to
bc3310e
Compare
There was a problem hiding this comment.
This was moved to remove transitive dependencies on React.
There was a problem hiding this comment.
The new switch component.
| label { | ||
| margin-bottom: 0; | ||
| } |
There was a problem hiding this comment.
Don't know why we set a margin by default, but it's rather annoying.
There was a problem hiding this comment.
The actual UI was moved into a separate file/component.
There was a problem hiding this comment.
UI that was previously in search.tsx.
| export function createElement<K extends keyof HTMLElementTagNameMap>( | ||
| tagName: K, | ||
| properties: Partial<HTMLElementTagNameMap[K]> | null = null, | ||
| ...children: (Node | string)[] | ||
| ): HTMLElementTagNameMap[K] { | ||
| const element = Object.assign(document.createElement(tagName), properties) | ||
| for (const child of children) { | ||
| element.append(typeof child === 'string' ? document.createTextNode(child) : child) | ||
| } | ||
| return element | ||
| } |
There was a problem hiding this comment.
This was moved to remove the transitive dependency on wildcard which causes build issues.
|
I can't seem to run this locally. Do I need to do anything special to generate the icons? |
|
I tried that 😄 |
|
Which error/problem do you get? You can also message me in Slack and I'll take a look when I have time. |
Not sure what changed, but running it locally is fixed now. Seems this broke the layout of search results headers: |
|
Should the keybind be scoped more tightly? Seems a little weird that |
|
nit: I don't love the lucide icons for case sensitivity and regex 😕 They seem imbalanced (specifically, the case sensitive icon looks too small), and the regex icon doesn't really look like a regex icon to me. (Also, should the text input be taller than the buttons?) |
No. They should all be a standard size (probably resolving to 32px height in this case). |
3 participants
This PR adds the inline file search to the file view.
Changelog
Test plan
Manually tested the SvelteKit and React versions of the search panel.