This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/msp/spec: require notionPageID if a production env is provisioned#62972
Merged
feat/msp/spec: require notionPageID if a production env is provisioned#62972
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bobheadxi and the rest of your teammates on |
jac
approved these changes
May 30, 2024
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that msp-ops pages are opt-in and requires you to provide a notion page ID, it's easy to miss providing one. Once a service gets a production environment, this should be required.
Closes https://linear.app/sourcegraph/issue/CORE-120
Test plan
#62973
Changelog
service.notionPageIDfor go/msp-ops