This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Use new cmp package to simplify comparisons#63029
Merged
varungandhi-src merged 1 commit intomainfrom Jun 3, 2024
Merged
chore: Use new cmp package to simplify comparisons#63029varungandhi-src merged 1 commit intomainfrom
varungandhi-src merged 1 commit intomainfrom
Conversation
kritzcreek
approved these changes
Jun 3, 2024
Contributor
kritzcreek
left a comment
There was a problem hiding this comment.
LGTM, I was confused about the "macro" comment at first... but after googling for "go macros" for a while I think you wanted to convey that there's no way to lazily evaluate the arguments to cmp.Or.
Contributor
Author
I did mean macro, because macros are much more common in languages like Rust, C etc. whereas lazy evaluation is not that common. In most languages, the usual or operator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is also a
cmp.Orfunction but since that's a function andnot a macro, it would cause all comparisons to always happen,
so we don't use that for chaining results.
Test plan
Covered by existing tests
Changelog