This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
Strum355
approved these changes
Jun 3, 2024
eseliger
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the interrupts where executed serially. Although quick this was not quick enough! Since you if pressed
ctrl+crapidly not all hooks would get executed.Hooks now get executed concurrently. In my own testing I could reliably get the orphaned process issue by just pressing
ctrl+ctwice. With this change, even pressing it very quickly - it still executed all hooks and thus all process where cleaned up.Test plan
Tested locally