Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Svelte: fix editor button styling#63080

Merged
camdencheek merged 1 commit intomainfrom
cc/fix-editor-wrap
Jun 4, 2024
Merged

Svelte: fix editor button styling#63080
camdencheek merged 1 commit intomainfrom
cc/fix-editor-wrap

Conversation

@camdencheek
Copy link
Member

@camdencheek camdencheek commented Jun 4, 2024

The editor button would wrap before the div would overflow, causing weird wrapping. This fixes that and also makes it a proper button.

Before:
screenshot-2024-06-04_10-23-29@2x

After:
screenshot-2024-06-04_10-24-22@2x

Test plan

Manual testing + screenshots above.

@cla-bot cla-bot bot added the cla-signed label Jun 4, 2024
Comment on lines 183 to 186
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused. Just removing it while I'm in here.

@camdencheek camdencheek force-pushed the cc/fix-editor-wrap branch from 189dbd6 to 6889b5e Compare June 4, 2024 16:27
@camdencheek camdencheek changed the title Nit: fix editor button styling Svelte: fix editor button styling Jun 4, 2024
@camdencheek camdencheek requested a review from a team June 4, 2024 16:27
@camdencheek camdencheek marked this pull request as ready for review June 4, 2024 16:27
@camdencheek camdencheek merged commit bf851d4 into main Jun 4, 2024
@camdencheek camdencheek deleted the cc/fix-editor-wrap branch June 4, 2024 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants