This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(graph): Add changelog entry for Python scip-ctags fix#63103
Merged
chore(graph): Add changelog entry for Python scip-ctags fix#63103
Conversation
mmanela
changed the title
| - Syntax highlighting works correctly for JSX files. [#62027](https://github.com/sourcegraph/sourcegraph/pull/62027) | ||
| - Changesets with a skipped CI check now have their CI status correctly displayed in the Batch Changes UI. [#62204](https://github.com/sourcegraph/sourcegraph/pull/62204) | ||
| - Fixed the Sourcegraph login page auto-redirecting to the single auth provider when request access is enabled. [#62376](https://github.com/sourcegraph/sourcegraph/pull/62376) | ||
| - Resolved scip-ctags issue for Python and C# where it was not detecting classes properly: [#62345](https://github.com/sourcegraph/sourcegraph/pull/62345) |
Contributor
There was a problem hiding this comment.
Someone reading the Changelog should not need to know what scip-ctags is. The point worth emphasizing here is that there was a bug - namely that (for Python) class declarations with decorators, such as @dataclass, were not detected correctly for type:symbol search and the symbols sidebar (and you can explain the wording for C# using the correct terminology, e.g. attributes). That bug was fixed. It's important to write Changelog notes in terms of what a Sourcegraph user would understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update changelog for 5.4 release to include the fix we did in scip-ctags
Test plan