enterprise-portal: update RPC for subscription domain and members#63105
enterprise-portal: update RPC for subscription domain and members#63105
Conversation
unknwon
force-pushed
the
jc/00-ep-rpc
branch
2 times, most recently
from
58c50e8 to
49a219d
Compare
| // Return only product subscriptions contains the member with the given permission, | ||
| // e.g. "cody_analytics::analytics::read". | ||
| string permission = 2; |
There was a problem hiding this comment.
should we support repeated string permission, to match multiple permissions? Would that be an OR or an AND?
There was a problem hiding this comment.
If we want repeated string permission, I think we should treat as AND, to be consistent and no confusion.
There was a problem hiding this comment.
The use case I'm thinking is "can this user either read or write to X" but I suppose it should just unsure that the relevant role has read and write explicitly, i.e. no permission implies another. So maybe we don't need a list here 🤔
There was a problem hiding this comment.
no permission implies another
I think this makes things a lot simpler, also this is what SAMS token scope spec does. (BTW "read/write" is an "action" in SAMS's term... 😂 😆 )
There was a problem hiding this comment.
On that note, should we use the term scope instead of permission here?
2 participants
Part of CORE-99
This PR adds new RPCs and fields for add and get/list subscription domain and members, prepare to be used by Cody Analytics related operations.
Test plan
CI