This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(Cody Gateway): add model field to Google completion request#63113
Merged
fix(Cody Gateway): add model field to Google completion request#63113
Conversation
Add the `Model` field to the `googleRequest` struct to include the model name in the request to the Google completion API. This change ensures that the model name is properly included in the request, which is necessary for Cody Gateway to function correctly. ## Changelog - Added `Model` field to `googleRequest` struct to include the model name in the request to the Google completion API.
kalanchan
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing
Modelfield to thegoogleRequeststruct to include the model name in the request to the Cody Gateway completion API.This change ensures that the model name is properly included in the request, which is necessary for Cody Gateway to function correctly.
Test plan
Verified connection to Gemini API directly works:
Response:
Verified connection to Cody Gateway endpoint works:
Response:
curl-ing the Cody Gateway endpoint returns the correct
modelnamegoogle/gemini-model:Response:
Before
curl-ing the Cody Gateway endpoint returns the following error because Model is missing, that's why model only contains the provider (
google) name:Response:
No Changelog is required for unreleased change.