This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(release): remove generate-notes from github release creation#63121
Merged
fix(release): remove generate-notes from github release creation#63121
Conversation
burmudar
force-pushed
the
wb-craig/fix-release-manifest
branch
from
29f2acd to
9f1b567
Compare
craigfurman
added
the
backport 5.4.5099
Collaborator
|
The backport to To backport this PR manually, you can either: Via the sg toolUse the sg backport -r 5.4.5099 -p 63121Via your terminalTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.4.5099 5.4.5099
# Navigate to the new working tree
cd .worktrees/backport-5.4.5099
# Create a new branch
git switch --create backport-63121-to-5.4.5099
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 817738a3ae98f0fc6e065388c2101dead32ae0d4
# Push it to GitHub
git push --set-upstream origin backport-63121-to-5.4.5099
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.4.5099If you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-63121-to-5.4.5099
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.4.5099
Once the pull request has been created, please ensure the following:
|
sourcegraph-release-bot
added
backports
release-blocker
craigfurman
pushed a commit
that referenced
this pull request
Jun 7, 2024
…elease creation (#63121) Generate notes currently generates a changelog all the way from the tag `app-2023` ... which means the content is more than what is allowed by github - hard cap of 125000 characters. - remove `generate-notes` cli flag when promoting releases - push only a single tag - fix token name used in changelog generation (cherry picked from commit 817738a)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate notes currently generates a changelog all the way from the tag
app-2023... which means the content is more than what is allowed by github - hard cap of 125000 characters.Test plan
CI
Changelog
generate-notescli flag when promoting releases