Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix(plg): banner styles#63287

Merged
taras-yemets merged 6 commits intomainfrom
ty/plg-invites-ui-feedback
Jun 17, 2024
Merged

fix(plg): banner styles#63287
taras-yemets merged 6 commits intomainfrom
ty/plg-invites-ui-feedback

Conversation

@taras-yemets
Copy link
Contributor

@taras-yemets taras-yemets commented Jun 17, 2024

Adresses UI feedback on https://github.com/sourcegraph/sourcegraph/pull/63231

Description Before After
Change dismiss button variant from "secondary" to "link" Screenshot 2024-06-14 at 14 34 30 Screenshot 2024-06-17 at 12 35 53
Fix banner content alignment Screenshot 2024-06-14 at 14 35 41Screenshot 2024-06-14 at 14 38 42 Screenshot 2024-06-17 at 12 31 14

Test plan

  • Tested manually (screenshots attached)

Changelog

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2024
@taras-yemets taras-yemets requested review from a team and rrhyne June 17, 2024 09:36
@taras-yemets taras-yemets marked this pull request as ready for review June 17, 2024 09:39
Copy link
Contributor

@rrhyne rrhyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so much better. Thanks!

@taras-yemets taras-yemets merged commit 02e9afc into main Jun 17, 2024
@taras-yemets taras-yemets deleted the ty/plg-invites-ui-feedback branch June 17, 2024 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants