This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
unknwon
approved these changes
Jun 18, 2024
bobheadxi
commented
Jun 18, 2024
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bobheadxi and the rest of your teammates on |
bobheadxi
force-pushed
the
robert/core-149-enterprise-portal-proto-rpc-for-createproductsubscription
branch
from
c2fc7fd to
662080c
Compare
bobheadxi
force-pushed
the
robert/core-149-enterprise-portal-proto-rpc-for-createproductsubscription
branch
from
662080c to
907c251
Compare
bobheadxi
deleted the
robert/core-149-enterprise-portal-proto-rpc-for-createproductsubscription
branch
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed RPC definition for creating an Enterprise Subscription, which is currently the
createProductSubscriptionGraphQL mutation, via Enterprise Portal. The RPC follows patterns suggested for "create" RPCs in https://google.aip.dev/133.One thing we didn't account for yet is the way AIP suggests handling IDs and names. It raises some interesting points about user-provided ID components in https://google.aip.dev/133#user-specified-ids - I'm pretty sure we don't want to introduce a user-controlled component to the currently randomized subscription ID, but we may want to introduce a "slug" identifier of sorts that must be unique. The default value can use something like https://pkg.go.dev/github.com/gosimple/slug to convert the display name. This would help us ensure duplicate subscriptions for the same customer aren't created.
Closes CORE-149. Implementation is tracked in a follow-up (CORE-155) - for now this will just return "unimplemented".
Test plan
CI