Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore/enterpriseportal: tweak maybeMigrate tracing#63448

Merged
bobheadxi merged 1 commit intomainfrom
ep-automigrate-o11y-tweak
Jun 24, 2024
Merged

chore/enterpriseportal: tweak maybeMigrate tracing#63448
bobheadxi merged 1 commit intomainfrom
ep-automigrate-o11y-tweak

Conversation

@bobheadxi
Copy link
Member

Fix an issue with context propagation and add a little more detail on automigration steps

Test plan

CI

@bobheadxi bobheadxi requested a review from unknwon June 24, 2024 19:13
@bobheadxi bobheadxi marked this pull request as ready for review June 24, 2024 19:13
@cla-bot cla-bot bot added the cla-signed label Jun 24, 2024
@bobheadxi bobheadxi requested a review from a team June 24, 2024 19:13
Comment on lines -85 to +87
redisClient.Get(context.Background(), versionKey).Val(),
redisClient.Get(ctx, versionKey).Val(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 💀

@bobheadxi bobheadxi merged commit ef50a04 into main Jun 24, 2024
@bobheadxi bobheadxi deleted the ep-automigrate-o11y-tweak branch June 24, 2024 21:07
bobheadxi added a commit that referenced this pull request Jun 25, 2024
…xt (#63455)

Follow-up to #63448 - we now get Redis spans, but not the database
operations that happen throughout a migration. Maybe this will do the
thing?

## Test plan

n/a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants