This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bobheadxi and the rest of your teammates on |
bobheadxi
force-pushed
the
06-26-feat_enterpriseportal_make_updateenterprisesubscriptionmembership_authoritative
branch
from
20973e6 to
e3e9898
Compare
bobheadxi
commented
Jun 26, 2024
Comment on lines
116
to
117
Member
Author
There was a problem hiding this comment.
This was unused, leftover from earlier iterations I think
bobheadxi
force-pushed
the
06-26-feat_enterpriseportal_make_updateenterprisesubscriptionmembership_authoritative
branch
from
e3e9898 to
66ea768
Compare
bobheadxi
force-pushed
the
ep-rename-codyanalytics-role
branch
from
ca6a30f to
02ee4f3
Compare
bobheadxi
force-pushed
the
06-26-feat_enterpriseportal_make_updateenterprisesubscriptionmembership_authoritative
branch
from
66ea768 to
aa06fbd
Compare
bobheadxi
referenced
this pull request
Jun 27, 2024
Studying Joe's work a bit more in depth I noticed that our API
representation of this role ("Cody Analytics admin") does not line up
with our internal representation ("customer admin").
Since we're already here, it's probably better to just align on
"customer admin" as the role everywhere, and figure out more granular
roles if we need it later.
Once it's rolled out and usages are migrated
(sourcegraph/sourcegraph-analytics#83), we can remove
the deprecated enum entirely
(https://github.com/sourcegraph/sourcegraph/pull/63502)
## Test plan
CI
jac
approved these changes
Jun 27, 2024
bobheadxi
force-pushed
the
06-26-feat_enterpriseportal_make_updateenterprisesubscriptionmembership_authoritative
branch
from
bd53dbd to
a7f71f7
Compare
bobheadxi
deleted the
06-26-feat_enterpriseportal_make_updateenterprisesubscriptionmembership_authoritative
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/CORE-199. AIP generally implies
UpdateRPCs are authoritative, which means that we should be deleting all roles memberships not provided toUpdateEnterpriseSubscriptionMembership. Most important outcome here is that we can actually remove roles from users by assigning them an empty role set[]Later we can add a "get roles" RPC to safely make these updates, and introduce a purely additive RPC if needed. It's not a huge deal right now because we only have 1 role ("customer admin")
Also removes the deprecated value from https://github.com/sourcegraph/sourcegraph/pull/63501.
Test plan
Unit tests, expanded with better table-driven cases and expanded assertions