This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
This commit fixes how tokens are decorated in the query input. The "chip" style needs to have lower presedence than the syntax highlighting so that it doesn't get split across the individual parts of e.g. a repo filter. This commit also removes the activeFilter extension. It was conflicting a bit with the filter decoration. This should be fine since it wasn't used for quite a while in the main search input either. I also noticed an issue with the size of the CodeMirror input in the saved searches form. I couldn't enter any query actually because the input was too "narrow". Adding `flex:1` fixes that.
stefanhengl
approved these changes
Jun 28, 2024
fkling
deleted the
fkling-srch-646-repo-and-other-filters-are-syntax-highlighted-incorrectly-in
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srch-646
This commit fixes how tokens are decorated in the query input. The "chip" style needs to have lower presedence than the syntax highlighting so that it doesn't get split across the individual parts of e.g. a repo filter.
This commit also removes the activeFilter extension. It was conflicting a bit with the filter decoration. This should be fine since it wasn't used for quite a while in the main search input either.
I also noticed an issue with the size of the CodeMirror input in the saved searches form. I couldn't enter any query actually because the input was too "narrow". Adding
flex:1fixes that.Test plan
Manual testing.