This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): Reference layout shift while loading data#63546
Merged
Conversation
This commit fixes an issue with layout shifting while loading data in the reference. The class/style was incorrectly applied causing additional padding to be added while data was loading. This commit fixes that and - adds a divider between the last list item and the loader - changes the default proxy to be S2. Dotcom didn't make sense anymore now that `pnpm dev:dotcom` does that explicitly.
camdencheek
approved these changes
Jun 28, 2024
fkling
deleted the
fkling-srch-613-svelte-jumping-bug-with-references-panel
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with layout shifting while loading data in the reference. The class/style was incorrectly applied causing additional padding to be added while data was loading. This commit fixes that and
pnpm dev:dotcomdoes that explicitly.Test plan
Manual testing