Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore: Add feature flag for new SCIP-based GraphQL APIs#63565

Merged
varungandhi-src merged 2 commits intomainfrom
vg/feature-flag
Jul 1, 2024
Merged

chore: Add feature flag for new SCIP-based GraphQL APIs#63565
varungandhi-src merged 2 commits intomainfrom
vg/feature-flag

Conversation

@varungandhi-src
Copy link
Contributor

@varungandhi-src varungandhi-src commented Jul 1, 2024

Makes partial progress towards https://linear.app/sourcegraph/issue/GRAPH-721

After this, I'll make necessary changes to the various configs to enable this feature flag
for dev, S2 and Sourcegraph.com. After that, I'll change the default to be false.

Test plan

  • Manually test that using experimentalFeatures.scipBasedAPIs can turn the feature on/off

Changelog

@cla-bot cla-bot bot added the cla-signed label Jul 1, 2024
@github-actions github-actions bot added team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/product-platform labels Jul 1, 2024
@kritzcreek
Copy link
Contributor

(Need to run sg bazel configure)

When turning the feature off via site-config I'm getting a not super pretty error, but I don't think we care about that. Can confirm it disables the API

{
  "errors": [
    {
      "message": "graphql: got nil for non-null \"UsageConnection\"",
      "path": [
        "usagesForSymbol"
      ]
    }
  ],
  "data": null
}

@varungandhi-src varungandhi-src merged commit e5d6a66 into main Jul 1, 2024
@varungandhi-src varungandhi-src deleted the vg/feature-flag branch July 1, 2024 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/product-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants