This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Add feature flag for new SCIP-based GraphQL APIs#63565
Merged
varungandhi-src merged 2 commits intomainfrom Jul 1, 2024
Merged
chore: Add feature flag for new SCIP-based GraphQL APIs#63565varungandhi-src merged 2 commits intomainfrom
varungandhi-src merged 2 commits intomainfrom
Conversation
Contributor
|
(Need to run When turning the feature off via site-config I'm getting a not super pretty error, but I don't think we care about that. Can confirm it disables the API |
kritzcreek
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes partial progress towards https://linear.app/sourcegraph/issue/GRAPH-721
After this, I'll make necessary changes to the various configs to enable this feature flag
for dev, S2 and Sourcegraph.com. After that, I'll change the default to be
false.Test plan
experimentalFeatures.scipBasedAPIscan turn the feature on/offChangelog