Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

suppress ResizeObserver type error#63572

Merged
sqs merged 1 commit intomainfrom
sqs/suppress-resizeob
Jul 1, 2024
Merged

suppress ResizeObserver type error#63572
sqs merged 1 commit intomainfrom
sqs/suppress-resizeob

Conversation

@sqs
Copy link
Member

@sqs sqs commented Jul 1, 2024

I was getting a weird TypeScript type error on a clean build.

$ pnpm -C client/web run build-ts
../testing/src/mockResizeObserver.ts:5:12 - error TS2339: Property 'ResizeObserver' does not exist on type 'never'.

Type-checking adds no value here anyway, and this is low risk to ignore.

Test plan

CI

I was getting a weird TypeScript type error on a clean build.

```
$ pnpm -C client/web run build-ts
../testing/src/mockResizeObserver.ts:5:12 - error TS2339: Property 'ResizeObserver' does not exist on type 'never'.
```

Type-checking adds no value here anyway, and this is low risk to ignore.
@sqs sqs requested a review from a team July 1, 2024 07:51
@cla-bot cla-bot bot added the cla-signed label Jul 1, 2024
@sqs sqs merged commit 841ccfe into main Jul 1, 2024
@sqs sqs deleted the sqs/suppress-resizeob branch July 1, 2024 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants