This repository was archived by the owner on Sep 30, 2024. It is now read-only.
clean up FilteredConnection filter types and code#63590
Merged
Conversation
sqs
force-pushed
the
sqs/fc-cleanup
branch
2 times, most recently
from
64cdbf5 to
faf4ca7
Compare
- Renames some types and fields for clarity:
- FilteredConnectionFilter -> Filter
- field name `values` -> `options`
- FilteredConnectionFilterValue -> FilterOption
- Avoids passing around unnecessary data
No behavior change. This makes it easier to use the FilterControl component.
fkling
approved these changes
Jul 3, 2024
fkling
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
values->optionsNo behavior change. This makes it easier to use the FilterControl component.
Test plan
Use existing filtered connections with filters (see the diff for a list of pages that contain this component).