This repository was archived by the owner on Sep 30, 2024. It is now read-only.
rcache: Explicitly pass redis pool to use#63644
Merged
Conversation
Member
Author
This was referenced Jul 4, 2024
Merged
Merged
eseliger
force-pushed
the
es/07-04-rcacheexplicitlypassredispooltouse
branch
4 times, most recently
from
2c8c0fd to
5666b30
Compare
ggilmore
approved these changes
Jul 9, 2024
Recently, this was refactored to also allow using the redispool.Store. However, that makes it very implicit to know where something is being written, so instead we pass down the pool instance at instantiation. This also gives a slightly better overview of where redispool is actually required. Test plan: CI passes.
eseliger
force-pushed
the
es/07-04-rcacheexplicitlypassredispooltouse
branch
from
5666b30 to
cd47721
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, this was refactored to also allow using the redispool.Store.
However, that makes it very implicit to know where something is being written, so instead we pass down the pool instance at instantiation.
This also gives a slightly better overview of where redispool is actually required.
Test plan: CI passes.