This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(codeintel): Move mock generation near interface package#64000
Merged
varungandhi-src merged 1 commit intomainfrom Jul 23, 2024
Merged
chore(codeintel): Move mock generation near interface package#64000varungandhi-src merged 1 commit intomainfrom
varungandhi-src merged 1 commit intomainfrom
Conversation
github-actions
bot
added
team/graph
varungandhi-src
requested review from
keynmol
and removed request for
kritzcreek
keynmol
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch moves the mocks for
codenav/../lsifstorepackage to a separate packagelsifstore/mocksinstead of it living incodenav. The problem is that if you updatethe
LsifStoreinterface, then you get an error when trying to regenerate mocks,as regeneration happens in the
codenavpackage, and that package's old mocksno longer satisfy the new interface (so there is an error when looking at other test
files). Moving the codegen to a separate package avoids this problem.
Test plan
Covered by existing tests