This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Bring back post-sign-up route to the backend router#64011
Merged
vovakulikov merged 1 commit intomainfrom Jul 23, 2024
Merged
Conversation
umpox
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inc-313
It should solve problems with the old auth flow in the new Svelte version. Currently, the go router doesn't know anything about post-sign-up flow, which is used in the JB Cody extension. Because of this, it passes it to the Svelte version which doesn't implement this route on the client (but the react version did have it on the client which is why it worked before, before we rolled out Svelte version by default)
Test plan