This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/requestclient: propagate original User-Agent as X-Forwarded-For-User-Agent#64113
Merged
feat/requestclient: propagate original User-Agent as X-Forwarded-For-User-Agent#64113
Conversation
bobheadxi
force-pushed
the
requestclient-forwardedforuseragent
branch
from
68922c1 to
73db77a
Compare
eseliger
approved these changes
Jul 26, 2024
Member
eseliger
left a comment
eseliger
left a comment
There was a problem hiding this comment.
We talked through this, seems fine
ggilmore
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates a for-reference-only record of the first
User-Agentseen when a request gets into Sourcegraph across services and contexts. This allows telemetry to try and indicate where a request originates from (https://github.com/sourcegraph/sourcegraph/pull/64112), rather than only having the most recent user-agent.A new header and
requestclient.ClientpropertyX-Forwarded-For-User-AgentandForwardedForUserAgentis used to explicitly forward this. Strictly speaking I think we're supposed to just forwardUser-Agentbut it looks like in multiple places we add/clobber theUser-Agentourselves.The gRPC propagator currently sets user-agent on outgoing requests, this change also makes that consistent with the HTTP transport, such that both only explicitly propagate
X-Forwarded-For-User-AgentTest plan
Unit tests