This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(appliance): don't include is_development builds in list of versions#64138
Merged
Chickensoupwithrice merged 1 commit intomainfrom Jul 30, 2024
Merged
Conversation
Contributor
Author
|
Double entry from release registry 
|
DaedalusG
approved these changes
Jul 29, 2024
craigfurman
pushed a commit
that referenced
this pull request
Jul 31, 2024
…ns (#64138) <!-- PR description tips: https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e --> @DaedalusG was running into warnings in the console due to the releaseregistry containing 2 entries for v5.4.0 (one was a development build) We're now filtering those ## Test plan <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> Manual testing ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c --> - fix(appliance): don't allow installation of development builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@DaedalusG was running into warnings in the console due to the releaseregistry containing 2 entries for v5.4.0 (one was a development build)
We're now filtering those
Test plan
Manual testing
Changelog