This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(bazel): surface error message when gazelle cant process glob expression#64214
Merged
BolajiOlajide merged 5 commits intomainfrom Aug 6, 2024
Merged
fix(bazel): surface error message when gazelle cant process glob expression#64214BolajiOlajide merged 5 commits intomainfrom
BolajiOlajide merged 5 commits intomainfrom
Conversation
Strum355
reviewed
Aug 1, 2024
BolajiOlajide
force-pushed
the
bo/nsc/gazelle-glob-fix
branch
from
800069a to
932e7c5
Compare
jhchabran
approved these changes
Aug 5, 2024
| echo "${stderr_output}" | ||
|
|
||
| gazelle_err_line=$(echo "${stderr_output}" | grep -m 1 -o '^gazelle:.*') | ||
| echo "gazelle encountered an issue processing glob expression, the BUILD file is not updated. ${gazelle_err_line}" |
Co-authored-by: Jean-Hadrien Chabran <jean-hadrien.chabran@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DINF-89
Gazelle sometimes have trouble processing glob expressions, and this isn't reported as a failure even though it ultimately results in the
BUILD.bazelnot being correctly updated.Test plan
In
client/web/BUILD.bazel, add a newsrcto theweb_libts_project target that includes a glob pattern.When you run
go run ./dev/sg bazel configure, the command should fail with an error message instead of returning exit 0.Changelog