This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Reapply "soap: Fix auto-redirect to IdP when SOAP is enabled" (#64234) #64244
Merged
Reapply "soap: Fix auto-redirect to IdP when SOAP is enabled" (#64234) #64244
Conversation
This reverts commit 81585cb.
github-actions
bot
added
team/product-platform
team/source
pjlast
approved these changes
Aug 2, 2024
Contributor
pjlast
left a comment
pjlast
left a comment
There was a problem hiding this comment.
I'd maybe just ask for a short comment like // Don't auto-redirect to sign-in when site is publicly accessible but other than that looks good
eseliger
force-pushed
the
es/reintroduce-auth-redirect
branch
from
e06c33a to
6d6c7ad
Compare
Member
Author
|
done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit https://github.com/sourcegraph/sourcegraph/commit/81585cb7ca98196695088d3b1a1038606ef2bcde.
Test plan
Tested in dotcom mode locally after clearing cookies and no redirect happens now.