This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: fix welcome banner flashing on reload#64251
Merged
camdencheek merged 1 commit intomainfrom Aug 2, 2024
Merged
Conversation
camdencheek
commented
Aug 2, 2024
|
|
||
| $: welcomeOverlayDismissed = $temporarySettingsStorage.get('webNext.welcomeOverlay.dismissed', false) | ||
| $: showWelcomeOverlay = !$welcomeOverlayDismissed ?? false | ||
| $: showWelcomeOverlay = !($welcomeOverlayDismissed ?? true) |
Member
Author
There was a problem hiding this comment.
If we have not yet loaded temporary settings, $welcomeOverlayDismissed will be undefined, which is falsy, which would cause us to show the welcome overlay. Instead, until we've loaded temporary settings, we prefer to not show the welcome overlay.
This means the overlay might pop up slightly after the page is loaded, but that's a reasonable price to pay for something that should happen ~once and keeps us from flashing the overlay every time.
jhchabran
approved these changes
Aug 2, 2024
evict
approved these changes
Aug 2, 2024
burmudar
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SRCH-831
Test plan
Local test that the banner no longer flashes on refresh.