This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Cody Web: Update Cody Web to 0.3.6 [React version]#64254
Merged
vovakulikov merged 2 commits intomainfrom Aug 2, 2024
Merged
Conversation
camdencheek
approved these changes
Aug 2, 2024
Comment on lines
+82
to
+84
| <ChatUi className={classNames({ [styles.hidden]: mode !== 'chat' })} /> | ||
|
|
||
| <div className={classNames(styles.chatHistory, { [styles.hidden]: mode !== 'history' })}> |
Member
There was a problem hiding this comment.
Q: why do we hide these rather than just render one or the other?
Contributor
Author
There was a problem hiding this comment.
good question, so the ChatUI and Chat history internally do a lot of things around subscription to the cody agent event. Hiding it with display:none helps with avoiding unnecessary loading states there
Member
There was a problem hiding this comment.
Got it, makes sense. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/SRCH-720/new-chat-button-in-side-panel-view
Closes https://linear.app/sourcegraph/issue/SRCH-808/chat-history-in-side-panel-view
This PR does a few things
Test plan
Changelog