This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): Make /cody/dashboard work with the new web app#64295
Merged
fix(svelte): Make /cody/dashboard work with the new web app#64295
Conversation
When navigating to `/cody/dashboard` and the new web app is enabled, the user gets a "Not found" error. This doesn't happen in the React app. The page doesn't exist in the new web app, hence the server should fall back to the old web app but that doesn't happen. Why? Because the server doesn't know about `/cody/dashboard` either. It only exists in the React app. Instead the server interprets this path as a (non-existing) repository page. When the new web app is enabled, repository pages are handled by the new web app, but since neither the repo nor the page exist in the new web app, the aforementioned error is thrown. Configuring this route on the server makes it so that the React app is served instead.
camdencheek
approved these changes
Aug 6, 2024
Member
Well that's not great 😄 |
fkling
deleted the
fkling-srch-765-fix-codydashboard-which-is-broken-on-s2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srch-765
When navigating to
/cody/dashboardand the new web app is enabled, the user gets a "Not found" error. This doesn't happen in the React app.The page doesn't exist in the new web app, hence the server should fall back to the old web app but that doesn't happen.
Why? Because the server doesn't know about
/cody/dashboardeither. It only exists in the React app.Instead the server interprets this path as a (non-existing) repository page. When the new web app is enabled, repository pages are handled by the new web app, but since neither the repo nor the page exist in the new web app, the aforementioned error is thrown.
Configuring this route on the server makes it so that the React app is served instead.
Test plan
Manual testing. Going to https://sourcegraph.test:3443/cody/dashboard loads the React app.