This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(batches): don't request unnecessary info that's likely to cause GH errors#64299
Merged
bahrmichael merged 4 commits intomainfrom Aug 7, 2024
Merged
fix(batches): don't request unnecessary info that's likely to cause GH errors#64299bahrmichael merged 4 commits intomainfrom
bahrmichael merged 4 commits intomainfrom
Conversation
camdencheek
approved these changes
Aug 6, 2024
Member
camdencheek
left a comment
camdencheek
left a comment
There was a problem hiding this comment.
I guess sometimes the best fix is just deleting the problematic thing! Good call, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes SRCH-802
After a long and unsuccessful hunt of eventual consistency errors, I noticed that we don't need the GraphQL fragments that are causing problems.
I introduced a simplified request, which succeeds reliably. What customers should see now is one error (see second picture below), which is followed by a retry, and then success.
Previously we've seen this error, sometimes less often, sometimes more, but customers saw it so often that it caused their batch changes to fail.
Customers may still see an initial error, which I've seen to reliably disappear on the first retry. It should not be a problem
Test plan
Manual testing
Changelog