This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(svelte): Add manual entries for repo sub pages to development proxy#64313
Merged
chore(svelte): Add manual entries for repo sub pages to development proxy#64313
Conversation
…roxy I noticed that non-svelte repo subpages haven't been redirected to the React app in local development (it works as expected in production). That's because the proxy doesn't know about them since they are not part of `knownRoutes`. We could update the server code to include those routes as well but that seems heavey handed just to make local development work. I think in this case it's fine to have manual entries for the handful of repo subpages that have not been migrated to Svelte yet.
camdencheek
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that non-svelte repo subpages haven't been redirected to the React app in local development (it works as expected in production).
That's because the proxy doesn't know about them since they are not part of
knownRoutes.We could update the server code to include those routes as well but that seems heavey handed just to make local development work.
I think in this case it's fine to have manual entries for the handful of repo subpages that have not been migrated to Svelte yet.
Test plan
Manual testing.