This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
A consequence of https://github.com/sourcegraph/sourcegraph/pull/64272 is that redirecting to the cody marketing page on dotcom didn't work. That's because `/cody` is not provided by the server as a known page. A simple fix would be to mark the link as external, but we'd have to keep in mind to do this in all places (present and future). A more "central" fix is to add this page to a hardcoded list of known pages that are not provided by the server.
umpox
approved these changes
Aug 7, 2024
fkling
deleted the
fkling-srch-851-clicking-on-cody-on-dotcom-when-not-signed-in-doesnt
branch
camdencheek
reviewed
Aug 7, 2024
| // Having a separate list is error-prone and should be avoided if possible. | ||
| const additionalKnownRoutes: string[] = [ | ||
| // Cody's marketing page | ||
| '^/cody/?$', |
Member
There was a problem hiding this comment.
Are there others here? e.g. routes handled by cloudflare and not the webapp?
Contributor
Author
There was a problem hiding this comment.
Probably. I tested the dotcom bottom links and they all work fine because we open them in a new tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srch-851
A consequence of https://github.com/sourcegraph/sourcegraph/pull/64272 is that redirecting to the cody marketing page on dotcom didn't work. That's because
/codyis not provided by the server as a known page.A simple fix would be to mark the link as external, but we'd have to keep in mind to do this in all places (present and future).
A more "central" fix is to add this page to a hardcoded list of known pages that are not provided by the server.
Test plan
Manual testing